Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

diagnostic: check for strings in XDG_DATA_DIRS #18074

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

To fix https://github.com/orgs/Homebrew/discussions/5549

One thing this ignores is canonicalizing paths (e.g. "${HOMEBREW_PREFIX}/share/" or any other equivalent paths)

@carlocab carlocab merged commit a61ac99 into Homebrew:master Aug 18, 2024
24 checks passed
@cho-m cho-m deleted the xdg-string branch August 18, 2024 02:44
@MikeMcQuaid
Copy link
Member

Thanks @cho-m!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants